Simplify URL launcher implementation

[mlaucis]

Summary

• Remove unnecessary canLaunchUrl check from link handler
• Use uri.hasScheme for cleaner URL vs route detection
• Remove Android manifest queries requirement
• Support mailto:, tel:, sms: schemes automatically

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Documentation
  • Updated the changelog to reflect simplification of the URL launcher process.
  • Revised the README to remove outdated Android manifest instructions, permission notes, and metadata best practices section.
• Refactor
  • Simplified link handling by removing unnecessary checks and manifest queries for URL launching.
  • Cleaned up AndroidManifest.xml by removing <queries> elements related to URL handling.

Walkthrough

The changes update documentation and code to simplify URL launching by removing pre-checks and Android manifest queries. Documentation sections related to Android intent queries, permissions, and metadata best practices are deleted. The code now directly launches URLs without checking availability, and the Android manifest no longer declares intent queries for external URLs.

Changes

File(s)	Change Summary
CHANGELOG.md	Updated to note URL launcher simplification and removal of manifest queries.
README.md	Removed Android manifest instructions, plugin permission notes, and metadata best practices section.
example/android/app/src/main/AndroidManifest.xml	Deleted <queries> and related <intent> elements for external URL handling.
lib/src/link_handler.dart	Refactored to remove canLaunchUrl check; now parses and launches URLs directly based on URI scheme.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant LinkHandler
    participant SystemBrowser

    User->>App: Triggers link navigation
    App->>LinkHandler: handleLink(link)
    LinkHandler->>LinkHandler: Parse link as URI
    alt URI has scheme
        LinkHandler->>SystemBrowser: Launch URL
        SystemBrowser-->>User: Opens external URL
    else No scheme
        LinkHandler->>App: Navigate in-app
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2baf1dc and 33ed6e6.

⛔ Files ignored due to path filters (1)

• example/pubspec.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• CHANGELOG.md (1 hunks)
• README.md (2 hunks)
• example/android/app/src/main/AndroidManifest.xml (0 hunks)
• lib/src/link_handler.dart (1 hunks)

💤 Files with no reviewable changes (1)

• example/android/app/src/main/AndroidManifest.xml

🔇 Additional comments (4)

lib/src/link_handler.dart (1)

22-31: LGTM! Clean simplification with proper error handling.

The refactor successfully simplifies the URL detection logic by using uri.hasScheme instead of substring checks, which is more robust and idiomatic. The removal of the canLaunchUrl pre-check streamlines the flow while maintaining proper error handling through the existing try-catch block and failure logging.

The reactive error handling approach (attempt launch → handle failure) is appropriate here since users will get immediate feedback through debug logs when URLs can't be launched.

README.md (2)

188-188: Documentation cleanup aligns with code simplification.

The whitespace cleanup and removal of Android manifest configuration instructions properly reflect the simplified URL launcher implementation that no longer requires manifest queries.

---

201-201: Consistent formatting improvement.

CHANGELOG.md (1)

6-6: Well-documented change entry.

The changelog entry accurately captures both aspects of the simplification: the code changes (removing canLaunchUrl check) and the configuration changes (removing Android manifest queries requirement).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.