feat(modal): adiciona suporte a ícone nas ações do modal #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luiz-s-vasconcellos
force-pushed
the
grid/DTHFUI-12113
branch
from
015eb6c to
5bd2ce6
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds icon support to modal action buttons by introducing an icon property to the PoModalAction interface. This enhancement allows developers to display icons alongside button labels in modal dialogs.
- Added
iconproperty toPoModalActioninterface with comprehensive documentation - Updated modal component template to bind icon properties to action buttons
- Enhanced sample/labs component to demonstrate icon functionality with new input fields
- Improved documentation consistency between
PoButtonandPoModalActionfor icon usage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| po-modal-action.interface.ts | Added optional icon property with documentation for string and TemplateRef support |
| po-modal.component.html | Bound [p-icon] property to both primary and secondary action buttons |
| sample-po-modal-labs.component.ts | Added primaryActionIcon and secondaryActionIcon properties, updated openModal() and restore() methods, reordered secondary action options array |
| sample-po-modal-labs.component.html | Added input fields for primary and secondary action icons, adjusted responsive grid classes for layout consistency |
| po-button-base.component.ts | Minor documentation improvements for icon property description and wording consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/ui/src/lib/components/po-modal/po-modal-action.interface.ts
Outdated
Show resolved
Hide resolved
...src/lib/components/po-modal/samples/sample-po-modal-labs/sample-po-modal-labs.component.html
Outdated
Show resolved
Hide resolved
luiz-s-vasconcellos
force-pushed
the
grid/DTHFUI-12113
branch
from
5bd2ce6 to
b8c5f0c
Compare
pedrodominguesp
previously approved these changes
Nov 10, 2025
O componente po-modal não permitia exibir ícones nos botões de ação. Adiciona a propriedade `icon` na interface `PoModalAction` e vincula `[p-icon]` nos botões primário e secundário do template do modal. Fixes DTHFUI-11656, DTHFUI-12113
luiz-s-vasconcellos
force-pushed
the
grid/DTHFUI-12113
branch
from
b8c5f0c to
fb7a79a
Compare
Atualiza o valor dos tokens: - ICON_SORT - ICON_SORT_ASC - ICON_SORT_DESC Adiciona os tokens: - ICON_ARROW_ARC_LEFT - ICON_PLUS - ICON_PROHIBIT Fixes DTHFUI-12113
luiz-s-vasconcellos
force-pushed
the
grid/DTHFUI-12113
branch
from
4b96b7c to
b3c7f9a
Compare
pedrodominguesp
approved these changes
Nov 19, 2025
anabye
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O componente po-modal não permitia exibir ícones nos botões de ação. Adiciona a propriedade
iconna interfacePoModalActione vincula[p-icon]nos botões primário e secundário do template do modal.modal
DTHFUI-11656, DTHFUI-12113
PR Checklist [Revisor]
Qual o comportamento atual?
Modal não permite adição de ícones nos botões de ação primária/secundária:
Qual o novo comportamento?
Modal aceita icon na interface PoModalAction:
Simulação