feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors#2746
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors#2746devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: wemerson.guimaraes <wemerson.guimaraes@totvs.com.br>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors
Summary
Expands the
PoColorPaletteEnumfrom 12 to 20 colors by addingColor13throughColor20with new hex values. Updates JSDoc documentation across all components that reference the color palette (po-badge, po-tag, po-chart, po-gauge, po-table, po-dynamic-view, po-menu) and fixes unit tests that previously used now-valid color values as out-of-range test cases.Changes:
Color13–Color20) topo-color-palette.enum.tspo-chart-seriedocs: fallback to black now starts at 21st series (was 13th)po-badge-base.component.spec.tsandpo-color-palette.service.spec.ts(color-13/color-20→color-21for out-of-range tests)Review & Testing Checklist for Human
color-13throughcolor-20are MISSING from this PR. Without corresponding.po-color-13….po-color-20class definitions in the stylesheets, these new enum values will be accepted in code but will not visually render any color. This likely needs a companion SCSS change before the feature is usable.#1a7a4f,#4a8c2a,#d4a017,#d47217,#c43a6a,#7a2dc8,#3f6ec8,#1ab5c8) are appropriate for the design system. These were not sourced from an existing design token set — confirm they meet brand/accessibility contrast requirements.po-badge-base.component.ts's color setter dynamically derives valid values from the enum rather than using a hardcoded range.npm run test:uilocally and confirm all 8483 specs pass. Then visually test a component (e.g.,po-tagorpo-badge) withcolor-13throughcolor-20to confirm whether colors render (they likely won't until SCSS is added).Notes
PoColorPaletteServiceandPoColorServiceuseObject.values(PoColorPaletteEnum)internally, so they automatically pick up the new values without code changes.