Skip to content

feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors#2746

Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1772570573-expand-color-palette
Open

feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors#2746
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1772570573-expand-color-palette

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 3, 2026

feat(color-palette): expand PoColorPaletteEnum from 12 to 20 colors

Summary

Expands the PoColorPaletteEnum from 12 to 20 colors by adding Color13 through Color20 with new hex values. Updates JSDoc documentation across all components that reference the color palette (po-badge, po-tag, po-chart, po-gauge, po-table, po-dynamic-view, po-menu) and fixes unit tests that previously used now-valid color values as out-of-range test cases.

Changes:

  • Added 8 new enum members (Color13Color20) to po-color-palette.enum.ts
  • Updated JSDoc color lists in 10 interface/component files
  • Updated po-chart-serie docs: fallback to black now starts at 21st series (was 13th)
  • Fixed test assertions in po-badge-base.component.spec.ts and po-color-palette.service.spec.ts (color-13/color-20color-21 for out-of-range tests)

Review & Testing Checklist for Human

  • CSS/SCSS definitions for color-13 through color-20 are MISSING from this PR. Without corresponding .po-color-13.po-color-20 class definitions in the stylesheets, these new enum values will be accepted in code but will not visually render any color. This likely needs a companion SCSS change before the feature is usable.
  • Verify the chosen hex values (#1a7a4f, #4a8c2a, #d4a017, #d47217, #c43a6a, #7a2dc8, #3f6ec8, #1ab5c8) are appropriate for the design system. These were not sourced from an existing design token set — confirm they meet brand/accessibility contrast requirements.
  • Verify badge color validation works correctly with the expanded range — specifically that po-badge-base.component.ts's color setter dynamically derives valid values from the enum rather than using a hardcoded range.
  • Test plan: Run npm run test:ui locally and confirm all 8483 specs pass. Then visually test a component (e.g., po-tag or po-badge) with color-13 through color-20 to confirm whether colors render (they likely won't until SCSS is added).

Notes

  • The PoColorPaletteService and PoColorService use Object.values(PoColorPaletteEnum) internally, so they automatically pick up the new values without code changes.
  • Requested by: wemerson.guimaraes
  • Link to Devin Session

Open with Devin

Co-Authored-By: wemerson.guimaraes <wemerson.guimaraes@totvs.com.br>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@alinelariguet alinelariguet added the Teste IA PR geradas por IA label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Teste IA PR geradas por IA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant