Reactive pos-container-contents#191
Conversation
0d72158 to
9a8f672
Compare
3b4a6b3 to
1eb909a
Compare
| return merge(this.store.additions$, this.store.removals$).pipe( | ||
| filter( | ||
| (quad) => | ||
| quad.graph.value == this.uri && |
There was a problem hiding this comment.
question: Why graph and not subject?
There was a problem hiding this comment.
thought: i wonder if the merge, pipe, filter pattern should be a convenience function on store. I guess we will need it a lot
There was a problem hiding this comment.
The graph limits changes to this container, i.e. ldp:contains triples in other documents won't trigger. In principle this minimises some triple injection issues, though in practice I was simply trying to find an efficient filter.
I'll add a test for it.
There was a problem hiding this comment.
I'm still expecting that we might want to reuse specific filters - at the moment a new observable is created for every call.
I don't want to prematurely optimise for that though - I think we can refactor with some performance oriented tests later.
If we end up doing that, it'll be more than just a convenience function.
8db0ded to
70d4a98
Compare
70d4a98 to
079fef7
Compare
Implements and closes #190
Builds on #186
LDPContainer.observeContainsas reactive equivalent toLDPContainer.containspos-container-contentsupdates its contents by observingLDPContainer.observeContains