Upgrade to Rails 7.2

[jcoyne]

No description provided.

[corylown]

Leaving this here so I (or someone else) can pick it up later. Looking specifically at rspec ./spec/models/upload_spec.rb:51:

For Rails 7.1 the following jobs get enqueued:

(ruby) ::ActiveJob::Base.queue_adapter
#<ActiveJob::QueueAdapters::TestAdapter:0x000000011a0ce138
 @enqueued_jobs=
  [{"job_class"=>"ExtractMarcRecordMetadataJob",
    "job_id"=>"4047019f-b6e0-4ceb-906c-64768ff637fc",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T19:12:24.983184000Z",
    "scheduled_at"=>nil,
    :job=>ExtractMarcRecordMetadataJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil},
   {"job_class"=>"ExtractFilesJob",
    "job_id"=>"39bfe9b6-6b86-47fc-a082-cd78f5b3e459",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T19:12:24.989364000Z",
    "scheduled_at"=>nil,
    :job=>ExtractFilesJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil}]>

For Rails 7.2:

#<ActiveJob::QueueAdapters::TestAdapter:0x0000000134dc6498
 @enqueue_after_transaction_commit=true,
 @enqueued_jobs=
  [{"job_class"=>"ActiveStorage::PurgeJob",
    "job_id"=>"b1a8d8b4-cc6d-4bb0-98cb-c882c8d40821",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/ActiveStorage::Blob/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T19:06:12.696891000Z",
    "scheduled_at"=>nil,
    :job=>ActiveStorage::PurgeJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/ActiveStorage::Blob/1"}],
    :queue=>"default",
    :priority=>nil}]>

If I remove the guards that were added for the Rails 7.1 upgrade the following jobs are enqueued for Rails 7.2:

(ruby) ::ActiveJob::Base.queue_adapter
#<ActiveJob::QueueAdapters::TestAdapter:0x0000000121a3da50
 @enqueue_after_transaction_commit=true,
 @enqueued_jobs=
  [{"job_class"=>"ExtractMarcRecordMetadataJob",
    "job_id"=>"8cae3951-787d-4180-9b56-4b33205839fe",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T18:56:12.406443000Z",
    "scheduled_at"=>nil,
    :job=>ExtractMarcRecordMetadataJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil},
   {"job_class"=>"ExtractFilesJob",
    "job_id"=>"33c0fe66-573e-4bd7-88a5-755e8f371067",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T18:56:12.440787000Z",
    "scheduled_at"=>nil,
    :job=>ExtractFilesJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil},
   {"job_class"=>"ActiveStorage::PurgeJob",
    "job_id"=>"20ca5fc4-1037-4b44-a1e5-240090d1fa9d",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/ActiveStorage::Blob/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T18:56:12.442401000Z",
    "scheduled_at"=>nil,
    :job=>ActiveStorage::PurgeJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/ActiveStorage::Blob/1"}],
    :queue=>"default",
    :priority=>nil},
   {"job_class"=>"ExtractMarcRecordMetadataJob",
    "job_id"=>"c08c70c7-8c7a-4f96-9b8c-71198e7b02b6",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T18:56:12.453324000Z",
    "scheduled_at"=>nil,
    :job=>ExtractMarcRecordMetadataJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil},
   {"job_class"=>"ExtractFilesJob",
    "job_id"=>"38c4ef00-0cfc-4045-9b39-48729c1df153",
    "provider_job_id"=>nil,
    "queue_name"=>"default",
    "priority"=>nil,
    "arguments"=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    "executions"=>0,
    "exception_executions"=>{},
    "locale"=>"en",
    "timezone"=>"UTC",
    "enqueued_at"=>"2025-01-31T18:56:12.454420000Z",
    "scheduled_at"=>nil,
    :job=>ExtractFilesJob,
    :args=>[{"_aj_globalid"=>"gid://aggregator/Upload/1"}],
    :queue=>"default",
    :priority=>nil}]>

This test failure seem legit. When I upload a file in development neither the ExtractMarcRecordMetadataJob nor the ExtractFilesJob gets enqueued as we'd expect.

[corylown]

addressed via #1190