Skip to content

OPS C1442068492-GES_DISC (S5P_L2__CLOUD_)#3834

Open
podaac-cicd[bot] wants to merge 1 commit intomainfrom
diff/ops/C1442068492-GES_DISC
Open

OPS C1442068492-GES_DISC (S5P_L2__CLOUD_)#3834
podaac-cicd[bot] wants to merge 1 commit intomainfrom
diff/ops/C1442068492-GES_DISC

Conversation

@podaac-cicd
Copy link
Contributor

@podaac-cicd podaac-cicd bot commented Sep 30, 2025

New association between l2ss-py and C1442068492-GES_DISC found in OPS.
Beginning verification of collection.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Test Results for C1442068492-GES_DISC

2 tests   1 ✅  1m 48s ⏱️
1 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit 7349a04.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added bug Something isn't working failed verification Other and removed unverified labels Sep 30, 2025
@github-actions
Copy link
Contributor

Action Needed
Tests have failed or encountered an unknown error. Open the status checks to view the logs and review the failure.

@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 89338d5 to bc1bd02 Compare October 1, 2025 18:18
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 89d9049 to 1ad2b39 Compare October 5, 2025 08:11
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 91eb26a to ad3b057 Compare October 8, 2025 08:18
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 5b82df2 to 966278e Compare October 11, 2025 08:12
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from e20c541 to a471854 Compare October 14, 2025 08:17
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from ba21641 to db2d065 Compare October 17, 2025 08:16
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 681782b to ea33bb3 Compare November 11, 2025 08:18
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 938af84 to 687c4ba Compare November 14, 2025 08:19
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 2a6192b to f09761e Compare November 17, 2025 08:20
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from dfb6672 to d510079 Compare November 20, 2025 08:21
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from c25fbfb to ff82e40 Compare November 26, 2025 09:08
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from cfd5b90 to 90c962d Compare November 29, 2025 09:08
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 6791d70 to 1861f3b Compare December 2, 2025 08:12
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from c0d54ed to ce45d9a Compare December 5, 2025 09:13
@podaac-cicd podaac-cicd bot force-pushed the diff/ops/C1442068492-GES_DISC branch from 9eee313 to f50db35 Compare December 8, 2025 09:17
@ocsmit
Copy link
Collaborator

ocsmit commented Mar 11, 2026

Leaving a comment here for reference.

The failure here is caused by the autotester is subsetting a portion of the granule which just simply does not have any data.

I.e. it grabs a science variable (cloud_base_height), masks the lat and lon variables where the science variable is NaN, and then checks if there is any coordinate data for the non NaN pixels. Problem is is that there is no science data in the subsetted portion being used so when mask is applied to the lat/lon vars they end up with completely empty arrays. (see image)

image

I verified with the autotester locally that when running with a larger subset BBox that it passes fully.

I also noticed that there is a break statement in the get_bounding_box method that stops the method from getting the full bounding box of the entire granule in the case that there are multiple polygons (such as with this collection). If this is intended behavior to get only a portion of the bounding box even before making a smaller bounding box with create_smaller_bounding_box, then it should be made clearer. Removing this break statement (L218) and getting full spatial extent bbox for the granule before calling create_smaller_bounding_box also results in a passing spatial subset test.

if polygons:
for polygon in polygons:
points = polygon['Boundary']['Points']
for point in points:
longitude_list.append(point.get('Longitude'))
latitude_list.append(point.get('Latitude'))
break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working failed verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants