Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export default class PodiumClient extends EventEmitter {
#resources;
#registry;
#metrics;
#counter;
#histogram;
#options;
#state;
Expand Down Expand Up @@ -144,6 +145,16 @@ export default class PodiumClient extends EventEmitter {
},
});

this.#counter = this.#metrics.counter({
name: 'podium_client_registered_podlet_count',
description: 'Number of podlets registered with the client',
labels: {
clientName: this.#options.name,
resourceName: undefined,
resourceUri: undefined,
},
});

this.#histogram = this.#metrics.histogram({
name: 'podium_client_refresh_manifests',
description: 'Time taken for podium client to refresh manifests',
Expand Down Expand Up @@ -221,6 +232,13 @@ export default class PodiumClient extends EventEmitter {
resourceOptions,
);

this.#counter.inc({
labels: {
resourceName: options.name,
resourceUri: options.uri,
},
});

resource.metrics.pipe(this.#metrics);

Object.defineProperty(this, options.name, {
Expand Down
34 changes: 24 additions & 10 deletions tests/integration.basic.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -390,29 +390,43 @@ tap.test(

tap.test('integration basic - metrics stream objects created', async (t) => {
const server = new PodletServer({ name: 'podlet' });
const client = new Client({ name: 'clientName' });
const client = new Client({ name: 'someClientName' });

const metrics = [];
client.metrics.on('data', (metric) => metrics.push(metric));
client.metrics.on('end', async () => {
t.equal(metrics.length, 3);
t.equal(metrics[0].name, 'podium_client_resolver_manifest_resolve');
t.equal(metrics[0].type, 5);
t.equal(metrics.length, 4);
t.equal(metrics[0].name, 'podium_client_registered_podlet_count');
t.equal(metrics[0].type, 2);
t.same(metrics[0].labels[0], {
name: 'name',
value: 'clientName',
name: 'clientName',
value: 'someClientName',
});
t.same(metrics[0].labels[1], {
name: 'resourceName',
value: service.options.name,
});
t.same(metrics[0].labels[2], {
name: 'resourceUri',
value: service.options.uri,
});
t.equal(metrics[1].name, 'podium_client_resolver_fallback_resolve');
t.equal(metrics[1].name, 'podium_client_resolver_manifest_resolve');
t.equal(metrics[1].type, 5);
t.same(metrics[1].labels[0], {
name: 'name',
value: 'clientName',
value: 'someClientName',
});
t.equal(metrics[2].name, 'podium_client_resolver_content_resolve');
t.equal(metrics[2].name, 'podium_client_resolver_fallback_resolve');
t.equal(metrics[2].type, 5);
t.same(metrics[2].labels[0], {
name: 'name',
value: 'clientName',
value: 'someClientName',
});
t.equal(metrics[3].name, 'podium_client_resolver_content_resolve');
t.equal(metrics[3].type, 5);
t.same(metrics[3].labels[0], {
name: 'name',
value: 'someClientName',
});

t.end();
Expand Down