-
Notifications
You must be signed in to change notification settings - Fork 12
ci: fix version bump during release #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Philippe Martin <[email protected]>
f5e9ec1 to
c185435
Compare
📝 WalkthroughWalkthroughThe release workflow now updates version fields in three additional package.json files (packages/api, packages/channels, packages/rpc) alongside existing packages during tagging, bumping, and PR-generation operations. Git staging is updated to include these newly touched files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| # Add the new version in package.json file | ||
| sed -i "s#version\":\ \"\(.*\)\",#version\":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" package.json | ||
| sed -i "s#version\":\ \"\(.*\)\",#version\":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" packages/api/package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): use a loop (given by gemini, untested):
PACKAGE_JSON_FILES="package.json packages/api/package.json packages/channels/package.json packages/extension/package.json packages/rpc/package.json packages/webview/package.json"
for file in ${PACKAGE_JSON_FILES};
do
sed -i "s#version":\ \"\(.*\)\",#version":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" $file
done
git add ${PACKAGE_JSON_FILES} build/Containerfile
(and similar for line 112)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll do this in a follow-up PR, when the tests/playwright module is included, to find the package.json files dynamically
Versions in some package.json are not updated during release.