Skip to content

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Dec 3, 2025

Versions in some package.json are not updated during release.

@feloy feloy requested review from a team and benoitf as code owners December 3, 2025 12:13
@feloy feloy requested review from dgolovin, gastoner and simonrey1 and removed request for a team December 3, 2025 12:13
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

📝 Walkthrough

Walkthrough

The release workflow now updates version fields in three additional package.json files (packages/api, packages/channels, packages/rpc) alongside existing packages during tagging, bumping, and PR-generation operations. Git staging is updated to include these newly touched files.

Changes

Cohort / File(s) Summary
Release workflow version management
.github/workflows/release.yaml
Extended version update operations to include packages/api/package.json, packages/channels/package.json, and packages/rpc/package.json during tagging, bump-to-next, and PR-generation steps. Updated git staging to include newly touched files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that all six package.json paths are correctly specified (no typos or missing packages)
  • Confirm git staging includes all newly touched files
  • Ensure the pattern consistency across tagging, bumping, and PR-generation steps

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing version bumps during the release process for additional package.json files.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem that motivated the fix (versions not being updated in some package.json files).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2cabbe and c185435.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build / windows-2022
  • GitHub Check: Build / ubuntu-24.04
  • GitHub Check: Build / macos-14
  • GitHub Check: Build extension OCI image
🔇 Additional comments (2)
.github/workflows/release.yaml (2)

94-125: Consistency check: Bump-to-next section mirrors tagging section.

The PR-generation section (lines 104-109 and 112) correctly adds the same three package.json files with consistent sed patterns and git staging. Once the file existence is verified from the previous comment, this section will be properly aligned.


62-82: Verify that the three newly-added package.json files exist and use matching JSON structure.

The tagging section adds sed commands for packages/api/package.json, packages/channels/package.json, and packages/rpc/package.json with the same pattern as existing files. If any of these files don't exist or use different JSON formatting (e.g., no space after the colon in version"), the sed command will not match and the version will not be updated, potentially leaving the release incomplete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@feloy feloy mentioned this pull request Dec 3, 2025
# Add the new version in package.json file
sed -i "s#version\":\ \"\(.*\)\",#version\":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" package.json
sed -i "s#version\":\ \"\(.*\)\",#version\":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" packages/api/package.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): use a loop (given by gemini, untested):

PACKAGE_JSON_FILES="package.json packages/api/package.json packages/channels/package.json packages/extension/package.json packages/rpc/package.json packages/webview/package.json"
for file in ${PACKAGE_JSON_FILES};
do
     sed -i  "s#version":\ \"\(.*\)\",#version":\ \"${{ steps.TAG_UTIL.outputs.extVersion }}\",#g" $file
done
git add ${PACKAGE_JSON_FILES} build/Containerfile

(and similar for line 112)

Copy link
Contributor Author

@feloy feloy Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll do this in a follow-up PR, when the tests/playwright module is included, to find the package.json files dynamically

@feloy feloy merged commit 13a0f80 into podman-desktop:main Dec 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants