Skip to content

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Nov 25, 2024

Signed-off-by: Philippe Martin [email protected]

What does this PR do?

Patch @kubernetes/client-node with async exec-auth (original PR kubernetes-client/javascript#2046)

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #9880
Fixes #8486

How to test this PR?

Have a kind context defined in your kubeconfig file and adapt it to have something similar to the one below(specifically the useer.exec part), and start Podman Desktop in main branch and with this PR.

In main, the app should eventually start (after a few minutes, as several calls to the exec command are done). With this PR, the app should start immediately.

apiVersion: v1
kind: Config
clusters:
  - name: kind-kind-cluster
    cluster:
      server: /redacted/
      certificate-authority-data: /redacted/
      insecure-skip-tls-verify: false
users:
  - name: kind-kind-cluster
    user:
      exec:
        apiVersion: client.authentication.k8s.io/v1beta1
        args:
          - '-c'
          - 'sleep 10'
        command: bash
        provideClusterInfo: false
contexts:
  - name: kind-kind-cluster
    context:
      cluster: kind-kind-cluster
      name: kind-kind-cluster
      user: kind-kind-cluster
preferences: {}
current-context: kind-kind-cluster
  • Tests are covering the bug fix or the new feature

@feloy feloy added the area/ci label Nov 25, 2024
@feloy feloy marked this pull request as ready for review November 25, 2024 08:06
@feloy feloy requested review from a team and benoitf as code owners November 25, 2024 08:06
@feloy feloy requested review from axel7083 and deboer-tim and removed request for a team November 25, 2024 08:06
@feloy feloy removed the area/ci label Nov 25, 2024
@feloy feloy merged commit eaf4c26 into podman-desktop:main Nov 27, 2024
43 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.15.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kubeconfig is read synchronously podman-desktop hangs upon startup

3 participants