fix: patch kubernetes-client-node to be able to handle cluster restart #9409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feloy
requested review from
axel7083,
cdrage and
jeffmaury
and removed request for
a team
Signed-off-by: Philippe Martin <[email protected]>
feloy
force-pushed
the
fix-9156/patch-kubernetes-client-rc7
branch
from
892ac63 to
9c20f3a
Compare
benoitf
changed the title
benoitf
approved these changes
Oct 16, 2024
cdrage
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
Patches kubernetes-client-node to be able to handle cluster restart
See kubernetes-client/javascript#1933
The fix has missed the release of the library version 1.0-rc7 for a few hours, and the next release is targeted to happen for next Kubernetes release (in a few months) (kubernetes-client/javascript#1937 (comment)).
For the moment, we are patching the library locally with the patch already included for next release (kubernetes-client/javascript#1937). We will need to remove the patch when we use the next release.
What issues does this PR fix or reference?
Part of #9156
Fixes #9348
How to test this PR?
create a Kind cluster with audit (https://kind.sigs.k8s.io/docs/user/auditing/)
start the cluster
start Podman Desktop
check that the cluster is marked as Reachable
stop the cluster
check that the cluster is marked as Unreachable
restart the cluster
check that the cluster is marked as Reachable
check that the cluster is not spammed with watch requests
Tests are covering the bug fix or the new feature