Skip to content

Add Android platform support (via Skip) for OpenCombineShim#113

Open
tifroz wants to merge 1 commit intopointfreeco:mainfrom
tifroz:android-support
Open

Add Android platform support (via Skip) for OpenCombineShim#113
tifroz wants to merge 1 commit intopointfreeco:mainfrom
tifroz:android-support

Conversation

@tifroz
Copy link

@tifroz tifroz commented Dec 19, 2025

Android (via Skip) always requires OpenCombine since there's no native Combine. The traits mechanism doesn't work in Skip's build pipeline, so Android needs to be added without the trait condition.

As I understand it, Linux behavior is functionally unchanged since the trait is auto-enabled by default on non-Darwin platforms anyway (see preprocessor condition below, found at the bottom of Package.swift)

#if !canImport(Darwin)
  package.traits.insert(
    .default(enabledTraits: ["OpenCombineSchedulers"])
  )
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant