Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to use swift-log for logging over OSLog due to its flexibility (ie. custom log destinations), so I added the ability to use swift-log instead of OSLog with
SyncEngine
through a new package trait.Since writing a real wrapper around OSLog seems to not be possible without giving up its built-in performance and redaction guarantees provided by the compiler, I've made this an either-or situation. That is, by enabling the
SharingGRDBSwiftLog
trait you lose the ability to use OSLog, but I think this is fine since the behavior is explicitly opt-in.