Update for swift-structured-queries boolean support #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Point to coenttb/swift-structured-queries feature/native-boolean-support branch - Add handling for new .bool case in QueryCursor - Updates to support proper boolean type handling for databases with native boolean types
Member
|
@coenttb Did you mean to close this? We'll need it whenever the corresponding StructuredQueries PR lands and a release is cut. |
Author
|
I did not, must have happened on accident when renaming the repo. Best if I PR again? Otherwise, the changes are so minimal (it's just a single case), it might be quicker for you to do yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates SharingGRDB to support the new boolean type handling introduced in pointfreeco/swift-structured-queries#141.
Changes
Package.swiftto point to thefeature/native-boolean-supportbranch of swift-structured-queries.boolcase inQueryCursor.swiftContext
As requested by @stephencelis in the swift-structured-queries PR, this demonstrates the changes needed in SharingGRDB to support proper boolean type handling for databases with native boolean types (like PostgreSQL) while maintaining backward compatibility with SQLite.
Testing
All tests pass with these changes.