-
Notifications
You must be signed in to change notification settings - Fork 76
Fix metadata observation. #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a01f0d3
Fix metadata observation.
mbrandonw 67ce6bf
Workaround for generated column observation behavior.
mbrandonw a53a9f3
optimization
mbrandonw fbf04a1
clean up
mbrandonw 6bb47d3
clean up
mbrandonw 18acc61
fix
mbrandonw 6ad28c9
fix
mbrandonw d410d18
update hasLastKnownServerRecord"
mbrandonw 2d01e9c
Update Sources/SQLiteData/CloudKit/SyncMetadata.swift
mbrandonw bf84eea
format
stephencelis ded0557
consistent order
stephencelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -621,6 +621,72 @@ | |
| """ | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *) | ||
| @Test(.attachMetadatabase(true)) | ||
| func observation() async throws { | ||
| let remindersList = RemindersList(id: 1, title: "Personal") | ||
| try await userDatabase.userWrite { db in | ||
| try db.seed { remindersList } | ||
| } | ||
| try await syncEngine.processPendingRecordZoneChanges(scope: .private) | ||
|
|
||
| @FetchAll( | ||
| SyncMetadata | ||
| .select { | ||
| RecordNameAndIsShared.Columns( | ||
| recordName: $0.recordName, | ||
| isShared: $0.share.isNot(nil) | ||
| ) | ||
| }, | ||
| database: userDatabase.database | ||
| ) | ||
| var rows | ||
| try await $rows.load() | ||
| #expect(rows == [RecordNameAndIsShared(recordName: "1:remindersLists", isShared: false)]) | ||
|
|
||
| _ = try await syncEngine.share(record: remindersList) { _ in } | ||
|
|
||
| try await Task.sleep(for: .seconds(0.5)) | ||
| #expect(rows == [RecordNameAndIsShared(recordName: "1:remindersLists", isShared: true)]) | ||
| } | ||
|
|
||
| @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *) | ||
| @Test(.attachMetadatabase(true)) | ||
| func observation_GeneratedColumn() async throws { | ||
| let remindersList = RemindersList(id: 1, title: "Personal") | ||
| try await userDatabase.userWrite { db in | ||
| try db.seed { remindersList } | ||
| } | ||
| try await syncEngine.processPendingRecordZoneChanges(scope: .private) | ||
|
|
||
| @FetchAll( | ||
| SyncMetadata | ||
| .select { | ||
| RecordNameAndIsShared.Columns( | ||
| recordName: $0.recordName, | ||
| isShared: $0.isShared | ||
| ) | ||
| }, | ||
| database: userDatabase.database | ||
| ) | ||
| var rows | ||
| try await $rows.load() | ||
| #expect(rows == [RecordNameAndIsShared(recordName: "1:remindersLists", isShared: false)]) | ||
|
|
||
| _ = try await syncEngine.share(record: remindersList) { _ in } | ||
|
|
||
| try await Task.sleep(for: .seconds(0.5)) | ||
| withKnownIssue("Query observation does not work with generated columns right now") { | ||
| #expect(rows == [RecordNameAndIsShared(recordName: "1:remindersLists", isShared: true)]) | ||
| } | ||
|
||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| @Selection struct RecordNameAndIsShared: Equatable { | ||
| let recordName: String | ||
| let isShared: Bool | ||
| } | ||
| #endif | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails without these changes.