Store internals: Refactor RootStore/ToState to "Core" protocol composition
#3460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95570eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by
UIBinding's internals, this pull request refactorsStorefrom a fully type-erased internalRootStoreclass and concretely composed key paths and closures using the internalToStatetype to a more efficient internal protocol composition called "Core".Corepreserves the underlyingStateandActiongenerics, avoiding unneeded, forced existential casts and it preserves the structure of individual key paths rather than appending the key paths directly, which is even known to be buggy. Benchmarks show an overall performance win here, if marginal, and the resulting code should be safer.