SyncUps speech client preview #3585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Feb 5, 2025
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Good catch, thanks! I think we used the mutability of this at one point but can't find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that there is some unnecessary state in the preview implementation of the
SpeechClientwhich is used in the SyncUps example.However in the SpeechRecognition example, which also contains a
SpeechClient, theisRecordingstate is used. But i'm wondering why there is an explicitfinishTaskendpoint instead of making use of cancellation.