[Examples] Declare store as static to avoid interference with Xcode previews #3618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce with Xcode previews
stephencelis
reviewed
Mar 7, 2025
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
@meltsplit Thanks for the PR! I think we'd definitely take the static change but I've made a few suggestions in one of the examples. Want to apply them to the rest? Then we'll be happy to merge your contributions 😄
Comment on lines
6
to
7
|
|
||
| @MainActor |
Member
There was a problem hiding this comment.
I don't believe this is needed since the App protocol is @MainActor.
Suggested change
| @MainActor |
Comment on lines
15
to
19
| if isTesting { | ||
| EmptyView() | ||
| } else { | ||
| SearchView(store: Self.store) | ||
| } |
Member
There was a problem hiding this comment.
Since we're not doing UI tests I think we can simplify:
Suggested change
| if isTesting { | |
| EmptyView() | |
| } else { | |
| SearchView(store: Self.store) | |
| } | |
| SearchView(store: Self.store) |
meltsplit
force-pushed
the
declare-store-as-static
branch
from
e63ad43 to
0b11dff
Compare
Contributor
Author
|
Thanks. @stephencelis I also removed |
stephencelis
reviewed
Mar 7, 2025
Examples/SpeechRecognition/SpeechRecognition/SpeechRecognitionApp.swift
Outdated
Show resolved
Hide resolved
Member
|
Thanks! |
stephencelis
approved these changes
Mar 7, 2025
Contributor
Author
|
@stephencelis |
meltsplit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am studying the example apps by referring to the tutorial.
I standardized the App.swift file.
Changes made:
I hope this change will help developers understand the testing and preview mechanisms better.