Skip to content

Enable binding workaround in release builds #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

Enable binding workaround in release builds #3640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a3729e
fix: Enable binding workaround in release builds
lukeredpath Apr 1, 2025
a8ed2ca
Merge branch 'main' into binding-issue-fix
stephencelis Apr 1, 2025
f2f54ef
Address flaky test
stephencelis Apr 1, 2025
39855d4
Make flakey tests easier to troubleshoot
stephencelis Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,21 @@ jobs:
- name: Update mtime for incremental builds
uses: chetan/git-restore-mtime-action@v2
- name: CaseStudies (SwiftUI)
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild-raw
- name: CaseStudies (UIKit)
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild-raw
- name: Search
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild-raw
- name: SyncUps
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild-raw
- name: SpeechRecognition
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild-raw
- name: TicTacToe
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild-raw
- name: Todos
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild-raw
- name: VoiceMemos
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild-raw

check-macro-compatibility:
name: Check Macro Compatibility
Expand Down
8 changes: 3 additions & 5 deletions Sources/ComposableArchitecture/Core.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,9 @@ final class IfLetCore<Base: Core, State, Action>: Core {
@inlinable
@inline(__always)
func send(_ action: Action) -> Task<Void, Never>? {
#if DEBUG
if BindingLocal.isActive && isInvalid {
return nil
}
#endif
if BindingLocal.isActive && isInvalid {
return nil
}
return base.send(actionKeyPath(action))
}
@inlinable
Expand Down
2 changes: 1 addition & 1 deletion Tests/ComposableArchitectureTests/EffectRunTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,6 @@ final class EffectRunTests: BaseTCATestCase {
await store.send(.tap).finish()
await queue.advance(by: .seconds(1))

try await Task.sleep(nanoseconds: 100_000_000)
try await Task.sleep(nanoseconds: 1_000_000_000)
}
}