Skip to content

Conversation

@ecito
Copy link

@ecito ecito commented Sep 30, 2025

No description provided.

@stephencelis
Copy link
Member

@ecito Without more context we're not sure what to do with this PR. The test seems to be invoking the internal mainActorNow API directly, which can for sure cause an issue when invoked on the main thread on a non-main queue. We've since reduced the number of calls to mainActorNow on main, so if you were experiencing an issue related to that, can you confirm if it was fixed or not? If not, can you provide a test that fails from how TCA uses mainActorNow rather than a test that invokes it directly?

@stephencelis
Copy link
Member

Going to close this PR since I'm not sure it's actionable, but feel to follow up with a comment or another PR. Thanks!

@ecito
Copy link
Author

ecito commented Oct 31, 2025

ah sorry, missed this question. very OK to close the PR, it was just to show code for discussion.

I can confirm these changes fixes the issue for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants