Skip to content

Fix empty message crash. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Fix empty message crash. #162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fc4d43
Fix empty message crash.
mbrandonw May 7, 2025
766ed47
wip
mbrandonw May 7, 2025
469c09d
wip
mbrandonw May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/IssueReportingTestSupport/SwiftTesting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ private func __recordIssue(
column: Int
) {
#if canImport(Testing)
let message = message == "" ? nil : message
Issue.record(
message.map(Comment.init(rawValue:)),
sourceLocation: SourceLocation(
Expand Down
28 changes: 28 additions & 0 deletions Tests/IssueReportingTests/SwiftTestingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,34 @@
&& issue.description == "Issue recorded: Something went wrong"
}
}

@Test
func emptyMessage() {
withKnownIssue {
reportIssue("")
}
}

@Test
func emptyMessage_async() async {
withKnownIssue {
reportIssue("")
}
}

@Test
func emptyMessage_throws() throws {
withKnownIssue {
reportIssue("")
}
}

@Test
func emptyMessage_asyncThrows() async throws {
withKnownIssue {
reportIssue("")
}
}
}

private struct Failure: Error {}
Expand Down