-
Notifications
You must be signed in to change notification settings - Fork 159
Expose observe
overloads for separate tracking and application of changes
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maximkrouk
wants to merge
8
commits into
pointfreeco:main
Choose a base branch
from
maximkrouk:expose-observe-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a8f3be2
Expose `observe` overloads for separate tracking and application of c…
maximkrouk 5df4eb9
Add minor performance optimization for onChange(of:perform:task:)
maximkrouk c058a10
Fix strong token capture in `observe(_:onChange:task)`
maximkrouk a1573d6
Merge branch 'main' into expose-observe-function
stephencelis ef2926b
feat: Fixes for expose-observe-function
maximkrouk 684393d
Merge remote-tracking branch 'github/expose-observe-function' into ex…
maximkrouk c37705e
Merge branch 'main' into expose-observe-function
stephencelis 189e51a
fix: Isolation tests
maximkrouk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
import SwiftNavigation | ||
import Perception | ||
import XCTest | ||
|
||
class NestingObserveTests: XCTestCase { | ||
#if swift(>=6) | ||
func testIsolation() async { | ||
await MainActor.run { | ||
var count = 0 | ||
let token = SwiftNavigation.observe { | ||
count = 1 | ||
} | ||
XCTAssertEqual(count, 1) | ||
_ = token | ||
} | ||
} | ||
#endif | ||
|
||
#if !os(WASI) | ||
@MainActor | ||
func testNestedObservation() async { | ||
let object = ParentObject() | ||
let model = ParentObject.Model() | ||
|
||
MockTracker.shared.entries.removeAll() | ||
object.bind(model) | ||
|
||
XCTAssertEqual( | ||
MockTracker.shared.entries.map(\.label), | ||
[ | ||
"ParentObject.bind", | ||
"ParentObject.value.didSet", | ||
"ChildObject.bind", | ||
"ChildObject.value.didSet", | ||
] | ||
) | ||
|
||
MockTracker.shared.entries.removeAll() | ||
model.child.value = 1 | ||
|
||
await Task.yield() | ||
|
||
XCTAssertEqual( | ||
MockTracker.shared.entries.map(\.label), | ||
[ | ||
"ChildObject.Model.value.didSet", | ||
"ChildObject.value.didSet", | ||
] | ||
) | ||
} | ||
#endif | ||
} | ||
|
||
#if !os(WASI) | ||
fileprivate class ParentObject: @unchecked Sendable { | ||
var tokens: Set<ObserveToken> = [] | ||
let child: ChildObject = .init() | ||
|
||
var value: Int = 0 { | ||
didSet { MockTracker.shared.track(value, with: "ParentObject.value.didSet") } | ||
} | ||
|
||
func bind(_ model: Model) { | ||
MockTracker.shared.track((), with: "ParentObject.bind") | ||
|
||
tokens = [ | ||
observe { _ = model.value } onChange: { [weak self] in | ||
self?.value = model.value | ||
}, | ||
observe { _ = model.child } onChange: { [weak self] in | ||
self?.child.bind(model.child) | ||
} | ||
] | ||
} | ||
|
||
@Perceptible | ||
class Model: @unchecked Sendable { | ||
var value: Int = 0 { | ||
didSet { MockTracker.shared.track(value, with: "ParentObject.Model.value.didSet") } | ||
} | ||
|
||
var child: ChildObject.Model = .init() { | ||
didSet { MockTracker.shared.track(value, with: "ParentObject.Model.value.didSet") } | ||
} | ||
} | ||
} | ||
|
||
fileprivate class ChildObject: @unchecked Sendable { | ||
var tokens: Set<ObserveToken> = [] | ||
|
||
var value: Int = 0 { | ||
didSet { MockTracker.shared.track(value, with: "ChildObject.value.didSet") } | ||
} | ||
|
||
func bind(_ model: Model) { | ||
MockTracker.shared.track((), with: "ChildObject.bind") | ||
|
||
tokens = [ | ||
observe { _ = model.value } onChange: { [weak self] in | ||
self?.value = model.value | ||
} | ||
] | ||
} | ||
|
||
@Perceptible | ||
class Model: @unchecked Sendable { | ||
var value: Int = 0 { | ||
didSet { MockTracker.shared.track(value, with: "ChildObject.Model.value.didSet") } | ||
} | ||
} | ||
} | ||
|
||
fileprivate final class MockTracker: @unchecked Sendable { | ||
static let shared = MockTracker() | ||
|
||
struct Entry { | ||
var label: String | ||
var value: Any | ||
} | ||
|
||
var entries: [Entry] = [] | ||
|
||
init() {} | ||
|
||
func track( | ||
_ value: Any, | ||
with label: String | ||
) { | ||
entries.append(.init(label: label, value: value)) | ||
} | ||
} | ||
#endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't this function body ignore the
tracking
parameter? Could we have a unit test to check that this actually works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it has to be used and I fixed it in my local version a while ago, but didn't push it, I'll push an update tomorrow