-
Notifications
You must be signed in to change notification settings - Fork 161
Expose observe overloads for separate tracking and application of changes
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maximkrouk
wants to merge
9
commits into
pointfreeco:main
Choose a base branch
from
maximkrouk:expose-observe-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a8f3be2
Expose `observe` overloads for separate tracking and application of c…
maximkrouk 5df4eb9
Add minor performance optimization for onChange(of:perform:task:)
maximkrouk c058a10
Fix strong token capture in `observe(_:onChange:task)`
maximkrouk a1573d6
Merge branch 'main' into expose-observe-function
stephencelis ef2926b
feat: Fixes for expose-observe-function
maximkrouk 684393d
Merge remote-tracking branch 'github/expose-observe-function' into ex…
maximkrouk c37705e
Merge branch 'main' into expose-observe-function
stephencelis 189e51a
fix: Isolation tests
maximkrouk dd42f44
Merge remote-tracking branch 'origin/main' into expose-observe-function
maximkrouk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an important change, I used a higher-level API here, to avoid duplication of derived observation handling and removed DispatchQueue.main.async in favor of
ActorProxyisolation on explicitly passedMainActor.shared, today I'm too tired to evaluate the impact, maybe I should fallback to duplication, please take a look 🙏