Set up dispatch sources after external write.#148
Merged
stephencelis merged 3 commits intomainfrom Apr 11, 2025
Merged
Conversation
3 tasks
ToineHulshof
approved these changes
Apr 11, 2025
stephencelis
approved these changes
Apr 11, 2025
mhayes853
pushed a commit
to mhayes853/swift-sharing
that referenced
this pull request
Aug 12, 2025
* Set up dispatch sources after external write. * fix * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147.
In #129 we made a change to support atomic writes of the file in
fileStorage. We made the assumption that if a file is deleted but the file exists (as is the case for atomic writes since they are a write+move), then we don't need to recreate the dispatch source. That worked well when the write was internally performed, but if someone atomically writes to the file it causes us to not re-setup the dispatch source. Now we always set up the dispatch source after a write.