An alternate implementation of excluded conflict resolution
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Jul 11, 2025
stephencelis
added a commit
that referenced
this pull request
Jul 11, 2025
* Reintroduce `excluded` to upsert clauses The original implementation in #95 had to be reverted due to issues with nested dynamic member lookup. This PR makes a breaking change to the `Updates` type, instead, to introduce this surface area. * wip * wip * An alternate implementation of `excluded` conflict resolution (#100) * wip
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Reintroduce `excluded` to upsert clauses The original implementation in pointfreeco#95 had to be reverted due to issues with nested dynamic member lookup. This PR makes a breaking change to the `Updates` type, instead, to introduce this surface area. * wip * wip * An alternate implementation of `excluded` conflict resolution (pointfreeco#100) * wip
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Reintroduce `excluded` to upsert clauses The original implementation in pointfreeco#95 had to be reverted due to issues with nested dynamic member lookup. This PR makes a breaking change to the `Updates` type, instead, to introduce this surface area. * wip * wip * An alternate implementation of `excluded` conflict resolution (pointfreeco#100) * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation may be the way to go. We can merge it into the other PR branch if we decide to go this direction.
Notably I did keep the overloads for the existing APIs, because it would be annoying to ignore
excludedwhen you don't need it and lose out on$0shorthand syntax:So in this PR, it still compiles.