jsonGroupArray filter fixes #103 #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.swift when joined table has no results
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Fix jsonGroupArray() automatic application of filter when QueryValue is Optional. * Comment corrections for jsonGroupArray() * refine fix to more closely match orginal. add assertion in SelectTests.swift when joined table has no results --------- Co-authored-by: Stephen Celis <[email protected]>
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Fix jsonGroupArray() automatic application of filter when QueryValue is Optional. * Comment corrections for jsonGroupArray() * refine fix to more closely match orginal. add assertion in SelectTests.swift when joined table has no results --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103 where FILTER clause is not consistently applied by default when calling
jsonGroupArray(). Also updates comments to reflect updated usage ofJSONRepresentation.selfin@Column(as:)and actual SQL emitted.