More flexible insert builder #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Aug 17, 2025
| @attached( | ||
| extension, | ||
| conformances: QueryRepresentable, | ||
| conformances: Selection, |
Member
Author
There was a problem hiding this comment.
@Selection now has its own conformance so that we can write generic algorithms against them. This is what allows them to be passed to Table.insert.
stephencelis
commented
Aug 17, 2025
| or conflictResolution: ConflictResolution? = nil, | ||
| _ columns: (TableColumns) -> TableColumns = { $0 }, | ||
| @InsertValuesBuilder<Self> values: () -> [Self], | ||
| @InsertValuesBuilder<Self> values: () -> [[QueryFragment]], |
Member
Author
There was a problem hiding this comment.
The @InsertValuesBuilder is now responsible for building up an array of query fragments to insert.
stephencelis
commented
Aug 17, 2025
| /// | ||
| /// - Parameter build: A result builder closure that prepares statements to insert every built row. | ||
| public init(@InsertValuesBuilder<any Table> _ build: () -> [any Table]) { | ||
| public init(@SeedsBuilder _ build: () -> [any Table]) { |
Member
Author
There was a problem hiding this comment.
The main gotcha in this PR is that we need a simultaneous release with SharingGRDB since it defines a seeds helper that will be incompatible with this feature.
stephencelis
commented
Aug 17, 2025
stephencelis
commented
Aug 17, 2025
| ) | ||
| } | ||
|
|
||
| private static func _insert<each ConflictTarget>( |
Member
Author
There was a problem hiding this comment.
Many of these overloads can be removed as the logic was moved into the result builder.
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Full-text search * wip * wip * Update FTS5.swift * wip * wip * wip * Make inserts more flexible * wip * wip * wip * wip * wip * wip * fix * wip
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Full-text search * wip * wip * Update FTS5.swift * wip * wip * wip * Make inserts more flexible * wip * wip * wip * wip * wip * wip * fix * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result builder powering
Table.insertcurrently expects the same type of value for each row inserted, which means they all need to beTablevalues, or they all need to beTable.Draftvalues, or they all need to be tuples of bindable values.This PR adds a bit more flexibility to the builder so that different values can be inserted at the same time so long as they encode into the same set of values.
For example, table values can be inserted along drafts:
And Swift values can be inserted alongside SQL:
The PR also allows column expressions from applying
@Table @Selectionto be inserted: