Database Functions Improvements #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to explicitly define more initializers. This does make me think `QueryBindable` needs to track the intermediate representation better so we could generate these.
mbrandonw
approved these changes
Sep 2, 2025
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Fix database function binding overflows We need to explicitly define more initializers. This does make me think `QueryBindable` needs to track the intermediate representation better so we could generate these. * wip * wip * wip * wip * wip * wip * wip * Update MigratingTo0.16.md * wip
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Fix database function binding overflows We need to explicitly define more initializers. This does make me think `QueryBindable` needs to track the intermediate representation better so we could generate these. * wip * wip * wip * wip * wip * wip * wip * Update MigratingTo0.16.md * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon a few deficiencies of #151:
QueryBindable.init?(queryBinding:). This is a breaking change for folks that define their own types conforming to `QueryRepresentable, but we are in the 0.x stage still, and custom query representations should be relatively uncommon. Still, we have a new migration guide to help.as:parameter to@DatabaseFunctionfor defining functions that work with custom query representations, like JSON.