Functions should be generic over their query-representable types #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Sep 4, 2025
| /// | ||
| /// - Parameter input: Expressions representing the arguments of the function. | ||
| /// - Returns: An expression representing the function call. | ||
| @_disfavoredOverload |
Member
Author
There was a problem hiding this comment.
This is for better compiler error messaging.
stephencelis
commented
Sep 4, 2025
Comment on lines
+129
to
+130
| public typealias Input = [String].JSONRepresentation | ||
| public typealias Output = [String].JSONRepresentation |
Member
Author
There was a problem hiding this comment.
This was allowing the generic callAsFunction to be called with invalid input when a representation was involved.
mbrandonw
approved these changes
Sep 4, 2025
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
…ntfreeco#156) * Functions should be generic over their query-representable types * wip
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
…ntfreeco#156) * Functions should be generic over their query-representable types * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice find by @acosmicflamingo.