Unroll reduces to statements in macro expansion. #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the compiler timeout issue for me. Thanks! |
stephencelis
approved these changes
Oct 3, 2025
bok-
pushed a commit
to bok-/swift-structured-queries-with-traits
that referenced
this pull request
Oct 12, 2025
* Unroll reduces to statements in macro expansion. * wip --------- Co-authored-by: Stephen Celis <[email protected]>
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Unroll reduces to statements in macro expansion. * wip --------- Co-authored-by: Stephen Celis <[email protected]>
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Unroll reduces to statements in macro expansion. * wip --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our latest changes we have macro code that expands to computing a big array and then
reduceing on it. That can cause the compiler to error out because it takes too long to type check. So I've unrolled thosereduces to be just a bunch of statements.