Skip to content

Conversation

@stephencelis
Copy link
Member

This way things don't behave strangely on other environments that set CI=1.

This way things don't behave strangely on other environments that set `CI=1`.
@stephencelis stephencelis merged commit 8b38279 into main Nov 25, 2025
3 checks passed
@stephencelis stephencelis deleted the github-env-var branch November 25, 2025 22:53
@rcarver
Copy link
Contributor

rcarver commented Nov 25, 2025

@stephencelis I think this will be problematic in my build environment of self-hosted GitHub actions.

@stephencelis
Copy link
Member Author

@rcarver Can you point your branch and verify? We can definitely set a custom env var if necessary but it'd be nice to rely on GitHub's env vars if possible.

@rcarver
Copy link
Contributor

rcarver commented Nov 25, 2025

From debugging previously I have a dump of the env, which includes GITHUB_ACTION

GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTION=__run_2
GITHUB_ACTIONS=true
GITHUB_ACTOR_ID=2343
GITHUB_ACTOR=rcarver

Here's a few vars that might be better?

GITHUB_JOB
GITHUB_WORKFLOW
GITHUB_REPOSITORY_OWNER=
GITHUB_REPOSITORY=

https://docs.github.com/en/actions/reference/workflows-and-actions/variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants