Skip to content

jsonGroupArray Improvements #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephencelis merged 13 commits into from
Jun 17, 2025
Merged

jsonGroupArray Improvements #60

stephencelis merged 13 commits into from
Jun 17, 2025

Conversation

@mbrandonw
Copy link
Member

@mbrandonw mbrandonw commented May 30, 2025 •
edited by stephencelis
Loading

Added:

  • An isDistinct option
  • An overload on optional tables that automatically filters out nil values and unwraps them
  • Documentation

@mbrandonw mbrandonw requested a review from stephencelis May 30, 2025 18:33
@PixelPirate
Copy link

PixelPirate commented Jun 2, 2025

Hi. What do you think about adding jsonGroupArray(isDistinct: true, …) here? If a reminders list has both milestones and reminders entries, then the resulting object will have duplicated entries without isDistinct. And I think in the case of the example here, and also in most cases in general, we don't want that. So an inclusion of that in the documentation here seems appropriate.

@mbrandonw
Copy link
Member Author

mbrandonw commented Jun 2, 2025

Hi @PixelPirate, thanks again for pointing this out! Just pushed some updates along with a test to show the behavior.

@stephencelis stephencelis changed the title Add docs about pre-loading multiple associations. jsonGroupArray Improvements Jun 17, 2025
@stephencelis stephencelis merged commit 5194b49 into main Jun 17, 2025
3 checks passed
@stephencelis stephencelis deleted the more-association-docs branch June 17, 2025 19:16
coenttb pushed a commit to coenttb/swift-structured-queries-postgres that referenced this pull request Oct 14, 2025
@mbrandonw @stephencelis
jsonGroupArray Improvements (pointfreeco#60)
a06a929 
Added:

  * An isDistinct option
  * An overload on optional tables that automatically filters out nil values and unwraps them
  * Documentation

Co-authored-by: Stephen Celis <[email protected]>
coenttb pushed a commit to coenttb/swift-structured-queries-postgres that referenced this pull request Oct 15, 2025
@mbrandonw @stephencelis
jsonGroupArray Improvements (pointfreeco#60)
ad208c7 
Added:

  * An isDistinct option
  * An overload on optional tables that automatically filters out nil values and unwraps them
  * Documentation

Co-authored-by: Stephen Celis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbrandonw @PixelPirate @stephencelis