feat(info): add ability to specify info links in footer#393
Open
mfcrocker wants to merge 1 commit intopokedextracker:masterfrom
Open
feat(info): add ability to specify info links in footer#393mfcrocker wants to merge 1 commit intopokedextracker:masterfrom
mfcrocker wants to merge 1 commit intopokedextracker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
This is mostly tested - I can't quite work out how to point it at my local version of the API so haven't done a full end to end test, but it works when manually setting
site="PokemonDB"in the newInfoLinkcomponent.It also doesn't implement PokeWiki.de or PokePedia.fr as those will require Pokemon name localisation before implementing, given their URLs use the German/French Pokemon names.