Replace Gen 1 and Gen 2 ball flairs with dex images#669
Open
SnowPhoenix wants to merge 2 commits intomasterfrom
Open
Replace Gen 1 and Gen 2 ball flairs with dex images#669SnowPhoenix wants to merge 2 commits intomasterfrom
SnowPhoenix wants to merge 2 commits intomasterfrom
Conversation
Raia
reviewed
May 22, 2021
Member
Raia
left a comment
Raia
left a comment
There was a problem hiding this comment.
Looks good but maybe we can consider changing the gen 3 dex class to gen3 for mod usability. It'd require that we schedule out a quick maintenance to run the flair change script on the sub though.
| const flairNames = { | ||
| "pokemontrades": { | ||
| "default" : "Gen 1 Dex", | ||
| "gen2" : "Gen 3 Dex", |
Member
There was a problem hiding this comment.
We'll probably want to do a flair migration and change the css class name from gen2 to gen3 for mod usability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.