Multi user

[garethedwards-tass]

No description provided.

[garethedwards-tass]

@pol-rivero also, here.

[ghedwards]

I think this is about ready for testing, there are a few things I haven't done, but are going to depend on the use case for them.

• Basic URL clone can't currently be tied to a specific login ( I don't see this as an immediate issue )
• You can clone a project using a specific account, then remove the account, this will generate a bunch of warnings in the console which can be fixed by adding the account with the same login
• Its not possible to switch accounts for a specific repository without deleting and re-creating it
• Its not possible to import an existing repository from your file system and have the ability to select an account ( this is pretty much the same as basic URL clone )

This is stuff that can be added over time if there are specific use cases for, but for me, this is about enough for me to start dogfooding these changes.

[pol-rivero]

Thank you for your hard work! I'm a bit busy at the moment, but when I have some time I'll merge this into a new branch and start getting this ready for release.

[pol-rivero]

I see you are still adding commits to this PR.
I'll set this to "draft". Let me know once it's finished (no longer a draft) and can be reviewed and merged.

[ghedwards]

I see you are still adding commits to this PR.
I'll set this to "draft". Let me know once it's finished (no longer a draft) and can be reviewed and merged.

You suggested you don't have the time at the moment?, I'm just working through stuff that might make the experience a bit better. Continuous improvement right ? If youre ready to merge stuff I can start creating other tickets and branches for additional work.

[pol-rivero]

That's correct, I don't have much time at the moment. Therefore, I'd rather not review partial/incomplete PRs.

Once you are happy with your implementation (either because you consider that the "Multiple accounts" feature is fully done, or because it's good enough and you no longer want to continue working on this feature), you can mark this PR as ready. Then, I'll merge into a new development branch, where I will make the required changes and improvements.

[ghedwards]

That's correct, I don't have much time at the moment. Therefore, I'd rather not review partial/incomplete PRs.

Once you are happy with your implementation (either because you consider that the "Multiple accounts" feature is fully done, or because it's good enough and you no longer want to continue working on this feature), you can mark this PR as ready. Then, I'll merge into a new development branch, where I will make the required changes and improvements.

What changes / improvements do you want to make ? Not sure I'm a "hand it over" and have at it kind of person. Have you tried the branch ? What's missing ?

[pol-rivero]

What changes / improvements do you want to make ?

Just some small bug fixes. For example, the "clone" dialog says there are no accounts even though I'm logged in.

---

Not sure I'm a "hand it over" and have at it kind of person.

I'm sorry, but that's the deal. You may not like it, but it's how open-source works.
You can either:

• Hand it over, after which the code becomes my responsibility and no further input is required from you (unless you want to contribute to other open issues). Of course, you will be credited in the release notes.
• Keep the changes in your fork and close this PR. Since my project is licensed under MIT, you can even change the license of your fork to a proprietary license, so that I cannot copy your implementation and must re-implement it from scratch.

The choice is yours, I won't judge you either way.

[ghedwards]

I'm aware of how open source works, but it doesn't mean collaboration dies because something is open source

[ghedwards]

Was gitlab working here prior to my changes ? Likely just a filter issue

[pol-rivero]

I'm aware of how open source works, but it doesn't mean collaboration dies because something is open source.

You are absolutely correct. You can continue contributing code for as long as you want. The only things that are ask are:

1. That PRs are complete and standalone. Enterprise usually focuses on small partial diffs to speed up code review, but at open-source we prefer monolithic PRs because we don't know when a contributor is going to disappear suddenly and leave an already merged feature unfinished.

2. That you accept that your code, once merged, becomes my responsibility and I may modify it in any way.

---

Was gitlab working here prior to my changes ? Likely just a filter issue

Yes, if the user is logged in with GitLab, it should display a list of repositories instead of a login button. Same with Bitbucket.
In fact, I've had a first look at the PR and it seems that in many places you are implementing this functionality only for GitHub.com, but this should be implemented in a generic way so that it also works for GitLab and Bitbucket.

[pol-rivero]

@ghedwards You added an incorrect commit: e2721db Replace github icons with flatpak icons

[ghedwards]

@ghedwards You added an incorrect commit: e2721db Replace github icons with flatpak icons

This was an upstream merge conflict, I've reverted the changes in this branch. Though I'm running with these icons in https://github.com/desktop-plus/desktop-plus and have been asking around for additional contributors.

[ghedwards]

@pol-rivero have you had a chance to play with the latest multi user updates? I'm on holiday for 3 weeks and won't have access to a laptop until I return

[pol-rivero]

I still haven't been able to check them out, sorry.
Don't worry about being away for 3 weeks, I'm still very busy and will probably be for a long while, so you will probably be back before I am.