Skip to content

Fix mypy errors#173

Merged
ritchie46 merged 6 commits intopola-rs:mainfrom
vyasr:test/ci
Sep 18, 2025
Merged

Fix mypy errors#173
ritchie46 merged 6 commits intopola-rs:mainfrom
vyasr:test/ci

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 17, 2025

There are a few issues that needed fixing:

  • The current requirements file is no longer current enough to be solvable because the pinned polars-cloud release of 0.0.11 doesn't actually exist on PyPI. I had uv compile a new set of requirements to fix that, which led to the subsequent issues.
  • The various new releases of polars-cloud since the last time this repository was updated have presumably led to some of the changes. I can't say for sure exactly what changed since I don't have access to polars cloud source code.
    • I could remove an attr-defined on the SchedulerClient. Not sure why, I didn't look at the old definition to find out.
    • I had to cast a query result. I'm guessing that this is because other result types didn't exist when this code was first added.
  • There was in indentation where get_status was being created as a free function rather than as a method on the PatchedComputeContext class. That wasn't triggering any mypy issues, but it was a clear bug so I fixed it.
  • DuckDB has temporarily lost typing due to the 1.4 release. We should be able to revert that change once they get it fixed, but in the meantime it would be good to get CI unblocked on this repo.

@vyasr vyasr changed the title Test CI Fix mypy errors Sep 18, 2025
This reverts commit 0a7c33e.
@ritchie46 ritchie46 merged commit f8f61ff into pola-rs:main Sep 18, 2025
3 checks passed
@ritchie46
Copy link
Member

Thanks!

@vyasr vyasr deleted the test/ci branch September 18, 2025 14:02
@vyasr vyasr mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants