fix(python): Support for ADBC drivers instantiated with dbc in DataFrame.write_database#26157
Conversation
dbc in write_databasedbc in DataFrame.write_database
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26157 +/- ##
==========================================
+ Coverage 81.00% 81.66% +0.66%
==========================================
Files 1805 1805
Lines 248021 248024 +3
Branches 3132 3131 -1
==========================================
+ Hits 200902 202551 +1649
+ Misses 46313 44668 -1645
+ Partials 806 805 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@alexander-beedie can you review? |
@ritchie46 No problem, will get on it tomorrow - this renewed ADBC driver push from the Columnar folks is likely to become relevant with things I'm doing at work too 🤔 |
|
Finally started reviewing (apologies for the delay); so far, so good. Will run a few local experiments (at home tonight) and merge tomorrow if all is well 👍 |
|
Let me know how you get on @alexander-beedie And sorry for the ping - just keen to get this in the next release! |
|
@alexander-beedie - friendly ping. Your review would be greatly appreciated. |
|
@henryharbeck Hi. Sorry for the late response, I've been watching this change closely for the recent couple weeks now. Since it is yet to be merged, would it be possible for I to take it back? It means a lot as a first time open source contributor. Appreciate your time in this change. |
Closes #26103
Supersedes #25889 (thanks @0x0Aro)
write_databaseused to assume that an instantiated ADBC connections had a corresponding Python package for the driver installed. With the recently releaseddbccli, this is no longer required.This is not specifically tested in CI, as the
dbccli is not installed there. The changes have been verified locally.Repro
Install
dbcand add postgresql (in the example here)Script
Before: raises even though an instantiated connection is passed to
write_databaseAfter: