fix(rust): Make tokio optional to allow wasm builds#26484
fix(rust): Make tokio optional to allow wasm builds#26484eitsupi wants to merge 3 commits intopola-rs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26484 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 1783 1783
Lines 243288 243288
Branches 3074 3074
=======================================
+ Hits 197236 197247 +11
+ Misses 45249 45238 -11
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failing test seems unrelated. |
|
I am not sure we want to. We move more and more to a model where tokio is required. I don't see the benefit of going through all those hoops. Why do we want it on the r-polars side? |
|
It just causes the wasm build to fail. Of course, this would be unnecessary if polars never plans to support wasm in the future, and I'm not going to argue with that. |
|
This will be helpful for my above-linked PR (#24058), which is nearing completion now and passing a significant portion of the test suite (albeit locally, not in CI right now). It would be great if WASM support could be brought back and kept, considering both the R bindings and Pyodide would need it. |
|
It's worth noting that tokio does have some limited wasm support: https://docs.rs/tokio/latest/tokio/#wasm-support. If Polars increasingly moves towards a tokio model that might be a way forward. Though I don't know if Polars currently depends on any of the tokio features not supported in Wasm. |
|
I would much rather welcome a PR that tries to use (unstable) tokio WASM support than us adding branches/ |
|
Okay, I don't have the bandwidth to put that much effort into making Polars WASM-compatible, so feel free to close it. |
#26353 introduce tokio as a default dependency, which make building polars for wasm impossible.
Found in pola-rs/r-polars#1726