feat: Parameter for pivot to always include value column name#26730
Merged
nameexhaustion merged 10 commits intopola-rs:mainfrom Mar 10, 2026
Merged
feat: Parameter for pivot to always include value column name#26730nameexhaustion merged 10 commits intopola-rs:mainfrom
nameexhaustion merged 10 commits intopola-rs:mainfrom
Conversation
github-actions
bot
added
enhancement
itamarst
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26730 +/- ##
==========================================
+ Coverage 81.63% 81.68% +0.04%
==========================================
Files 1806 1805 -1
Lines 248032 248037 +5
Branches 3127 3132 +5
==========================================
+ Hits 202484 202600 +116
+ Misses 44742 44631 -111
Partials 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orlp
previously requested changes
Mar 2, 2026
| separator | ||
| Used as separator/delimiter in generated column names in case of multiple | ||
| `values` columns. | ||
| column_naming : {'auto', 'always_combine'} |
Member
There was a problem hiding this comment.
Says always_combine rather than combine.
| separator | ||
| Used as separator/delimiter in generated column names in case of multiple | ||
| `values` columns. | ||
| column_naming : {'auto', 'always_combine'} |
| for i in 0..on_columns.height() { | ||
| let mut name = String::new(); | ||
| if values.len() > 1 { | ||
| if values.len() > 1 || matches!(column_naming, PivotColumnNaming::Combine) { |
Member
There was a problem hiding this comment.
Can you please use a match here so this fails if we ever add new stuff?
let combine = match column_naming {
PivotColumnNaming::Combine => true,
PivotColumnNaming::Auto => values.len() > 1
}
Contributor
Author
|
Will do. |
nameexhaustion
previously approved these changes
Mar 9, 2026
nameexhaustion
changed the title
nameexhaustion
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26700