build(rust): Bump up numpy and pyo3 to 0.28#26743
build(rust): Bump up numpy and pyo3 to 0.28#26743florianvazelle wants to merge 5 commits intopola-rs:mainfrom
Conversation
Preserve existing behavior and silence PyO3 deprecation warning about automatic FromPyObject implementation for Clone pyclasses.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #26743 +/- ##
==========================================
+ Coverage 80.94% 81.67% +0.73%
==========================================
Files 1805 1805
Lines 248090 248098 +8
Branches 3131 3131
==========================================
+ Hits 200825 202643 +1818
+ Misses 46460 44650 -1810
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does the test suite pass if we skip the |
|
Hi @orlp, if we skip the It's seems to implicitly implement the trait |
orlp
left a comment
There was a problem hiding this comment.
Could you do one more pass over everything, aggressively removing from_py_object in favor of the skip, unless it really doesn't compile without?
|
Yes, that's how I proceeded initially pyclasses with the |
Hi 👋
I submit this PR to bump
pyo3andnumpydependencies from 0.27 to 0.28.pyo3deprecates the automatic implementation ofFromPyObjectforClonepyclasses, so I tried to preserve the current behavior (this is the main change made).Feedback and suggestions are very welcome 🙂