fix: Raise error instead of panic for unsupported pivot aggregate#26863
Open
RenzoMXD wants to merge 1 commit intopola-rs:mainfrom
Open
fix: Raise error instead of panic for unsupported pivot aggregate#26863RenzoMXD wants to merge 1 commit intopola-rs:mainfrom
RenzoMXD wants to merge 1 commit intopola-rs:mainfrom
Conversation
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26863 +/- ##
==========================================
+ Coverage 81.00% 81.65% +0.65%
==========================================
Files 1805 1805
Lines 248021 248020 -1
Branches 3132 3132
==========================================
+ Hits 200902 202530 +1628
+ Misses 46313 44684 -1629
Partials 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panic was caused by
.expect()inIRBuilder::group_by()(builder_ir.rs:303) when schema derivation failed for an unsupported aggregate expression. Changedgroup_by()to returnPolarsResult<Self>so the error propagates as anInvalidOperationErrorinstead of panicking.Closes #25860
Closes #26843