feat: optimizations arguments
#1635
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors optimization flag handling in LazyFrame operations by introducing a new helper function forward_old_opt_flags to centralize deprecation handling for old optimization parameters. The changes update the $explain() method to use the new QueryOptFlags object and deprecate individual optimization parameters.
Key Changes:
- Added
forward_old_opt_flags()function to handle deprecated optimization parameters - Refactored
lazyframe__explain()to useQueryOptFlagsobject viaoptimizationsparameter - Updated documentation examples to use
writeLines()instead ofcat()for better output display
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/lazyframe-utils.R | Added forward_old_opt_flags() helper function to centralize deprecated parameter handling with validation |
| R/lazyframe-frame.R | Refactored lazyframe__explain() to accept QueryOptFlags object and added engine parameter; updated examples to use writeLines() |
eitsupi
force-pushed
the
optimizations-args
branch
from
23785a0 to
b605a42
Compare
eitsupi
commented
Nov 11, 2025
Collaborator
Author
|
I'll add some tests tomorrow... |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.