Skip to content

Fixed closing } for extern C#17

Open
westonMS wants to merge 1 commit intopolarfire-soc:mainfrom
westonMS:main
Open

Fixed closing } for extern C#17
westonMS wants to merge 1 commit intopolarfire-soc:mainfrom
westonMS:main

Conversation

@westonMS
Copy link

Description

In the file mss_pdma.h, which is located in ~30 places, it uses the

#ifdef __cplusplus
extern "C" {
#endif 

for C++ cross compilation. But it is missing the necessary closing bracket

#ifdef __cplusplus
}
#endif

preventing compilation and throwing an error.

I simply added the closing bracket that is present in all other .c and .h files as far as I have found. This is a minor fix for C++ compilation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Using the mss pdma sample code, I inserted it into a C++ project in SoftConsole (using the Hello World C++ as a base). I then made the change and compiled it. Such a changed allowed the example code to compile unlike before and work just like the C version.

Test Configuration:

  • Reference design release:
  • Hardware:
  • HSS version:
  • Bare metal examples version:
  • Buildroot / Yocto release:

Checklist:

  • I have reviewed my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works
  • I have added a maintainers file for any new board support

Signed-off-by: Weston <wms29@byu.edu>
Signed-off-by: Weston Smith <wms29@byu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant