-
Notifications
You must be signed in to change notification settings - Fork 85
#592 重新注册时使用最后一次的注册实例信息 #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SkyeBeFreeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com.tencent.polaris.discovery.client.flow.RegisterFlow#doRunHeartbeat方法内有心跳失败重注册逻辑,是否需要RegisterStateManager.putRegisterState注册request呢?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
============================================
- Coverage 20.46% 20.21% -0.25%
- Complexity 833 929 +96
============================================
Files 334 364 +30
Lines 13233 15020 +1787
Branches 1702 1889 +187
============================================
+ Hits 2708 3037 +329
- Misses 10171 11608 +1437
- Partials 354 375 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9cc2e2a to
3bb31ea
Compare
|
最后一次注册的request会覆盖前面的instanceRegisterRequest,重注册时用最新的request是符合预期的 |
|
提交有冲突,先解决冲突。 |
48f2fd3 to
6b85bbf
Compare
|
@jianliu |
|
@SkyeBeFreeman 是最后一次注册时更新state中的InstanceRegisterRequest,心跳失败重注册自动使用最后一次注册的InstanceRegisterRequest来重新注册 2、什么场景下,InstanceRegisterRequest会有变更? |
@jianliu 心跳失败重注册时,是否需要更新state中的InstanceRegisterRequest呢? |
...ery-client/src/main/java/com/tencent/polaris/discovery/client/flow/RegisterStateManager.java
Show resolved
Hide resolved
SkyeBeFreeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
#592 每次注册时刷新RegisterState,重新注册时使用最后一次的注册实例信息