Skip to content

fix:fix circuit breaker report wrong status when exception occurred. #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SkyeBeFreeman wants to merge 2 commits into from
Closed

fix:fix circuit breaker report wrong status when exception occurred. #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a001f6
fix:fix circuit breaker report wrong status when exception occurred.
SkyeBeFreeman Dec 9, 2025
6581f5e
fix:fix circuit breaker report wrong status when exception occurred.
SkyeBeFreeman Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../java/com/tencent/polaris/plugins/circuitbreaker/composite/utils/CircuitBreakerUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ public static ServiceRule fillDefaultCircuitBreakerRuleInNeeded(Resource resourc
String statusCodes = IntStream.range(500, 600)
.mapToObj(String::valueOf)
.collect(Collectors.joining(","));
statusCodes += ",-1";
codeMatchStringBuilder.setValue(StringValue.of(statusCodes));
errorConditionBuilder.setCondition(codeMatchStringBuilder);
failureBlockConfigBuilder.addErrorConditions(errorConditionBuilder);
Expand Down
2 changes: 1 addition & 1 deletion ...a/com/tencent/polaris/plugins/circuitbreaker/composite/utils/CircuitBreakerUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void testFillDefaultCircuitBreakerRuleInNeeded() {
assertThat(addedRule.getRuleMatcher().getSource().getService()).isEqualTo("testCallerService");
// 验证错误条件
assertThat(addedRule.getBlockConfigs(0).getErrorConditions(0).getCondition().getValue().getValue())
.isEqualTo("500,501,502,503,504,505,506,507,508,509,510,511,512,513,514,515,516,517,518,519,520,521,522,523,524,525,526,527,528,529,530,531,532,533,534,535,536,537,538,539,540,541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,559,560,561,562,563,564,565,566,567,568,569,570,571,572,573,574,575,576,577,578,579,580,581,582,583,584,585,586,587,588,589,590,591,592,593,594,595,596,597,598,599");
.isEqualTo("500,501,502,503,504,505,506,507,508,509,510,511,512,513,514,515,516,517,518,519,520,521,522,523,524,525,526,527,528,529,530,531,532,533,534,535,536,537,538,539,540,541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,559,560,561,562,563,564,565,566,567,568,569,570,571,572,573,574,575,576,577,578,579,580,581,582,583,584,585,586,587,588,589,590,591,592,593,594,595,596,597,598,599,-1");
// 验证触发条件
assertThat(addedRule.getBlockConfigs(0).getTriggerConditions(0).getTriggerType()).isEqualTo(CircuitBreakerProto.TriggerCondition.TriggerType.ERROR_RATE);
assertThat(addedRule.getBlockConfigs(0).getTriggerConditions(0).getErrorPercent()).isEqualTo(50);
Expand Down