Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new AWS Athena integration that enables SQL-based querying of data stored in Amazon S3. The integration supports parameterized queries with type hints, configurable result displays, pagination, and asynchronous query status checking for long-running queries.
Key Changes:
- SQL query execution with parameterized placeholders and type hint support (
?:<type>) - Prepared statement management for efficient query execution
- Client-side pagination (5 results per page) and filtering of query results
- Asynchronous query status polling with manual refresh capability for queries exceeding 30 seconds
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| integration.js | Core integration logic including Athena client initialization, query execution, prepared statement management, result formatting, and query status polling |
| component/block.js | Ember component handling pagination, filtering, and query status checking UI interactions |
| template/block.hbs | Handlebars template for displaying query results, statistics, pagination controls, and error states |
| config/config.json | Integration configuration including AWS credentials, query settings, and display attribute options |
| package.json | Package dependencies including AWS SDK, Luxon for date parsing, Lodash, and async utilities |
| styles/style.less | Styling for result containers, pagination controls, filter inputs, and error messages |
| README.md | Comprehensive documentation covering setup, configuration, attribute specifications, and IAM permissions |
| LICENSE | MIT license for the integration |
| .prettierrc | Code formatting configuration |
| .github/workflows/run-int-dev-checklist.yml | CI workflow for integration development checklist |
| .github/workflows/release-current-version.yml | CI workflow for versioning and releases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ralucarusu-tc
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration is based off our AWS DynamoDB integration.
The integration supports setting your own Athena SQL Query which will be parameterized and run. You can configure what fields are displayed in the details and summary block via integration options.
Results are displayed in the details template and include paging of results (5 per page) and filtering on result values.
If a query takes longer than 30 seconds to complete, it will return a "Still running" page and the user can manually click a button to check query status.