fix: Disallow nil passing to create_dirs() #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To tackle deletion and creation path issues, commit 6e1fa15 ("feat: Enable user to get "out" of a worktree") added the possibility of passing nil to change_dirs(). But the problems can be solved in a better way: When deleting, check if the selection is the current tree then change dir to gitroot_dir() if so. When creating, add gitroot_dir() as prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To tackle deletion and creation path issues, commit 6e1fa15 ("feat: Enable user to get "out" of a worktree") added the possibility of passing nil to change_dirs(). But the problems can be solved in a better way:
When deleting, check if the selection is the current tree then change dir to gitroot_dir() if so. When creating, add gitroot_dir() as prefix.