Skip to content

Fix mobile overflow in dashboard overview and mobile nav#10524

Open
vin-dKR wants to merge 2 commits intopolarsource:mainfrom
vin-dKR:fix-issue-9957
Open

Fix mobile overflow in dashboard overview and mobile nav#10524
vin-dKR wants to merge 2 commits intopolarsource:mainfrom
vin-dKR:fix-issue-9957

Conversation

@vin-dKR
Copy link
Copy Markdown
Contributor

@vin-dKR vin-dKR commented Mar 23, 2026

📋 Summary

Related Issue: Fixes #9957

Fixes mobile Safari overflow on the logged-in dashboard around the Overview header controls so the page fits the viewport without horizontal scrolling.

🎯 What

  • Updated Overview filter controls to be responsive:
    • Mobile: replaced SegmentedControl with a Select dropdown for CHART_RANGES
    • Desktop/tablet: kept existing SegmentedControl behavior unchanged
  • Improved mobile spacing/layout between range control and Customize button (justify-between)
  • Moved the mobile SelectItem checkmark indicator to the right for cleaner UX
  • Matched mobile control heights for better alignment between the select and Customize button
  • Fixed additional mobile overflow source in layout by updating MobileNav width behavior (w-screenw-full/max-w-full + clipped horizontal overflow)

🤔 Why

Issue #9957 reports that dashboard controls under “Overview” overflow on mobile Safari and cause horizontal scrolling. This hurts usability and makes the screen look broken on iPhone/Safari-sized viewports. These changes ensure controls remain usable and contained on mobile while preserving the existing larger-screen UI.

🔧 How

  • Added a mobile-only dropdown using the shared UI Select atom in OverviewSection
  • Kept existing segmented control visible only on md+
  • Applied mobile-only alignment/spacing classes to prevent overlap and overflow
  • Applied targeted class overrides for select-item indicator placement and trigger sizing
  • Adjusted MobileNav container sizing to avoid viewport-width overflow edge cases on mobile browsers

🧪 Testing

  • I have tested these changes locally
  • All existing tests pass (uv run task test for backend, pnpm test for frontend)
  • I have added new tests for new functionality
  • I have run linting and type checking (uv run task lint && uv run task lint_types for backend)

Test Instructions

  1. Open dashboard while logged in on a mobile viewport (Safari responsive mode and/or iPhone Safari).
  2. Confirm controls under Overview do not overflow horizontally and page fits screen width.
  3. Verify mobile shows dropdown + Customize button aligned on one row.
  4. Verify desktop/tablet still shows the original segmented control + Customize.
  5. Open mobile nav and confirm no right-side overflow/horizontal scroll is introduced.

🖼️ Screenshots/Recordings

Before/after screenshots for mobile Safari overflow fix (attach in PR UI).

📝 Additional Notes

  • Scope is intentionally limited to responsive behavior and layout containment.
  • No backend/API changes.
  • Existing desktop behavior is preserved.

✅ Pre-submission Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant tests
  • All tests pass locally
  • AI/LLM Policy: If I used AI assistance, I have tested and executed the code locally (not just "vibe-coded")

Related issue: UI overflows on mobile safari #9957

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 23, 2026

@vin-dKR is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

Removed unnecessary fragment around CheckoutElements.
@vin-dKR
Copy link
Copy Markdown
Contributor Author

vin-dKR commented Apr 11, 2026

@pieterbeulque could you please check this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI overflows on mobile safari

1 participant