Fix mobile overflow in dashboard overview and mobile nav#10524
Open
vin-dKR wants to merge 2 commits intopolarsource:mainfrom
Open
Fix mobile overflow in dashboard overview and mobile nav#10524vin-dKR wants to merge 2 commits intopolarsource:mainfrom
vin-dKR wants to merge 2 commits intopolarsource:mainfrom
Conversation
|
@vin-dKR is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
Removed unnecessary fragment around CheckoutElements.
Contributor
Author
|
@pieterbeulque could you please check this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Related Issue: Fixes #9957
Fixes mobile Safari overflow on the logged-in dashboard around the
Overviewheader controls so the page fits the viewport without horizontal scrolling.🎯 What
Overviewfilter controls to be responsive:SegmentedControlwith aSelectdropdown forCHART_RANGESSegmentedControlbehavior unchangedCustomizebutton (justify-between)SelectItemcheckmark indicator to the right for cleaner UXCustomizebuttonMobileNavwidth behavior (w-screen→w-full/max-w-full+ clipped horizontal overflow)🤔 Why
Issue #9957 reports that dashboard controls under “Overview” overflow on mobile Safari and cause horizontal scrolling. This hurts usability and makes the screen look broken on iPhone/Safari-sized viewports. These changes ensure controls remain usable and contained on mobile while preserving the existing larger-screen UI.
🔧 How
Selectatom inOverviewSectionmd+MobileNavcontainer sizing to avoid viewport-width overflow edge cases on mobile browsers🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)Test Instructions
Overviewdo not overflow horizontally and page fits screen width.Customizebutton aligned on one row.Customize.🖼️ Screenshots/Recordings
Before/after screenshots for mobile Safari overflow fix (attach in PR UI).
📝 Additional Notes
✅ Pre-submission Checklist
Related issue: UI overflows on mobile safari #9957