onboarding: Separate submit for review to other endpoint

[Yopi]

Split save details and submit for review into two separate endpoints. This clarifies the button, and makes sure that submitting for review is explicit

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
polar	Ready	Preview, Comment	Apr 24, 2026 6:11am
polar-sandbox	Ready	Preview, Comment	Apr 24, 2026 6:11am

[github-actions]

Preview Environment
URL: https://polar-preview-vm.taildbff7b.ts.net/pr-10837
API: https://polar-preview-vm.taildbff7b.ts.net/pr-10837/v1/
Logs: backend
SHA: 59ef65c5b9d927084fc65c6c2de69b5f3b763440

[pieterbeulque]

I was about to open a similar issue just now. Thanks for this.

I introduced this issue by moving the POST /v1/organizations to step 3. In our initial onboarding, step 2 did the POST /v1/organizations and step 3 was a PATCH /v1/organizations/:id. However, a PATCH that sets the organization details has the side-effect of triggering an organization review.

I merged the two steps in a single API call to avoid triggering a premature organization review. So, another fix could be to decouple the organization review initialization from the PATCH /v1/organizations endpoint, then revert the onboarding to a POST on step 2 + a PATCH on step 3, and just rely on the API to validate the slug.

As another option, I was considering maybe adding a private /validate-slug endpoint that validates a slug without trying to create the organization.

Do with it whatever you want 😁

[github-actions]

OpenAPI Changes

Operations

• 🔼 POST /v1/organizations/{id}/submit-review (added)

[Yopi]

@pieterbeulque took your advise, and reverted the POST/PATCH in the organization creation, and added a specific endpoint to submit review which we call from the dashboard

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
TestUpdateOrganization/test_submit_for_review_requires_relevant_fields[anonymous]	View Logs

[frankie567]

I would love us to find a way to use a proper Pydantic schema for this rather than manually spinning up validation logic like this