Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenAPI ChangesNo changes detected in the OpenAPI schema. |
Contributor
|
🚀 Expo preview is ready!
|
Contributor
|
Preview Environment |
Contributor
|
Sorry @sebastianekstrom , I made some other changes you need to rebase ontop of, but I think this makes sense! |
Yopi
force-pushed
the
chore/fix-committed-metrics-backend
branch
from
e941f94 to
a573728
Compare
_not_in_trial / _in_trial truncated both trial_end and the bucket timestamp and compared those. `trial_end < t + interval` gives the same answer without the date_trunc calls on either side.
Yopi
force-pushed
the
chore/fix-committed-metrics-backend
branch
from
a573728 to
03cd11b
Compare
Yopi
approved these changes
Apr 24, 2026
Contributor
|
@sebastianekstrom ok to go? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committed metrics were calculated relative to request time now, which made them sensitive to timezone and the current date. This means the same query could return different values depending on when and where it was requested from.
The fix is to calculate committed metrics relative to each bucket timestamp instead.
Example: For a single subscription at
$500that starts atTand is canceled atT+2, historical cMRR should be:T: $500T+1: $500T+2: $0T+3: $0With
timestamp, looking at theT+1bucket always returns$500.With
now, if you open the dashboard atT+3and look back atT+1, that old bucket can be recalculated using the current time instead of the bucket’s time, which can incorrectly make it drop to$0.