Draft
Conversation
We want to avoid loading the entire SDK, because it doesn't get lazily loaded, but having inline imports in every method does not look great either. By splitting the client and implementation like this, we can get code that is a bit nicer to read without getting a memory footprint in the cases where we dont want it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenAPI ChangesNo changes detected in the OpenAPI schema. |
Contributor
|
Preview Environment |
Member
|
Looks smart :) That said, if I'm not mistaken, Speakeasy supports TypedDict as well... So we could do, still with proper type checking: await self._sdk.members.create_member_async(
request={
"customer_id": customer_id,
"email": email,
"name": name,
"external_id": external_id,
}
)And avoid to load heavy Pedantic models. WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to avoid loading the entire SDK, because it doesn't get lazily loaded, but having inline imports in every method does not look great either.
By splitting the client and implementation like this, we can get code that is a bit nicer to read without getting a memory footprint in the cases where we dont want it.